Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove creation of stray fits file #1338

Merged
merged 1 commit into from
Jul 30, 2024
Merged

remove creation of stray fits file #1338

merged 1 commit into from
Jul 30, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Jul 30, 2024 •
edited
Loading

Regression tests all pass: https://github.com/spacetelescope/RegressionTests/actions/runs/10165236470

This PR removes the creation of a fits file during create_gridded_psf_model.

Closes #1328

Local testing running roman_elp (which previously produced a tmp_sca01.fits) shows that the stray fits file is no longer produced with this PR.

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@codecov Codecov
Copy link

codecov bot commented Jul 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.10%. Comparing base (cae1d64) to head (ce0bb9d).
Report is 183 commits behind head on main.

Files with missing lines Patch % Lines
romancal/lib/psf.py 84.61% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1338      +/-   ##
==========================================
+ Coverage   79.05%   79.10%   +0.04%     
==========================================
  Files         117      117              
  Lines        7846     7830      -16     
==========================================
- Hits         6203     6194       -9     
+ Misses       1643     1636       -7
Flag Coverage Δ *Carryforward flag
nightly 63.36% <ø> (ø) Carriedforward from cae1d64

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review July 30, 2024 16:25
@braingram braingram requested a review from a team as a code owner July 30, 2024 16:25
@braingram braingram requested a review from schlafly July 30, 2024 16:25
schlafly
schlafly approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Brett!

@schlafly schlafly merged commit 31d9b15 into spacetelescope:main Jul 30, 2024
33 of 34 checks passed
@braingram braingram deleted the stray_fits_file branch July 30, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlafly schlafly schlafly approved these changes

Assignees
No one assigned
Labels
no-changelog-entry-needed testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running roman_elp leaves a fits file in the current directory.
2 participants
@braingram @schlafly